[Freeciv-Dev] Re: (PR#8754) effects patch

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

On Wed, 4 Aug 2004, Jason Short wrote:

> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
>
> I think find_eff_group should return a pointer to the group.
> ruleset_cache_add should take a pointer to a group.  Groups should be
> sent to the client by name, not by ID.  Doing it by ID assumes that the
> eff code in server and client works exactly the same way...I think.

Uh, no it doesn't. The groups list is sent in its entirety from the
server to the client. This is akin to using unit or city ids. Makes no
difference.

> However there doesn't seem to be much documentation on this so it's hard
> for me to tell what's going on.

Last time I tried to poke into the map code I got a headache as well.
:-)

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa