[Freeciv-Dev] (PR#8789) iso-view drawing buglet

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8789 >

There is a bug in drawing in iso-view.

With isotrident, you move a one-move unit diagonally down you'll see 
that part of its flag gets overwritten.  (The bug isn't confined to this 
case but it's easiest to find like this.)

This is because of a bug in gui_rect_iterate causing D_M (middle 
drawing) to be set erronously for the bottom tiles of the iteration. The 
  bottom tile should have D_T but not D_M or D_B.  The attached patch 
fixes it.

jason

? eff
? flags
? data/flags
Index: client/mapview_common.h
===================================================================
RCS file: /home/freeciv/CVS/freeciv/client/mapview_common.h,v
retrieving revision 1.62
diff -u -r1.62 mapview_common.h
--- client/mapview_common.h     14 May 2004 02:23:42 -0000      1.62
+++ client/mapview_common.h     20 May 2004 21:48:27 -0000
@@ -199,7 +199,8 @@
        if (GRI_x_itr < GRI_x1 - 1) {                                       \
          draw |= D_R;                                                      \
        }                                                                   \
-       if (GRI_y_itr > GRI_y0) {                                           \
+       if (GRI_y_itr > GRI_y0                                              \
+           && GRI_y_itr < GRI_y1 - 1) {                                    \
          draw |= D_M;                                                      \
        }                                                                   \
        if (GRI_y_itr > GRI_y0 + 1) {                                       \