Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2004:
[Freeciv-Dev] (PR#8754) effects patch
Home

[Freeciv-Dev] (PR#8754) effects patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#8754) effects patch
From: "Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>
Date: Wed, 19 May 2004 14:54:06 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

> [per@xxxxxxxxxxx - Mon May 17 13:35:39 2004]:
> 
> The patch uses city_affected_by_wonder() heavily, but this function is
> still all hardcoded. I assume the intention is to reuse the equiv_range
> here instead of the hardcoding, and generalizing this function using the
> game.global_wonders array and equiv_range info should be pretty easy. This
> redefines equiv_range slightly, which should be documented at least, but I
> fail to see any sanity in equiv_range _not_ being equal to the wonder's
> effective range. That is, since the eff patch cannot by design have
> differently ranged effects in one wonder anyway.

Yes, that is more or less the idea. But a wonder can have differently
ranged effects. As long as they do not have the same target type. The
target type is defined by the use of the get_*_bonus functions.




[Prev in Thread] Current Thread [Next in Thread]