[Freeciv-Dev] Re: (PR#8754) effects patch

["Per Inge Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

This patch is very neat, and it is also a lot shorter than both gen eff
and gen impr. Still, not everything is obvious, so please add function
comments to the patch as soon as possible.

I would like some more comments on how it intends to handle the corner
cases. The reason why gen eff is so much more complicated is because it
generalizes all the corner cases. I must assume you do not wish to do so,
but this should be spelled out to enable a fair comparison between the two
approaches.

Especially comment on Spy_Resistant, effects that affect units (not unit
effects, but eg Sun Tzu and United Nations) and Palace. I am sure Mike can
add more problem cases to this list.

In gen eff, defn->outside determines if a particular effect that affects
units only works for units in cities or for all units. Example: Barracks
only work inside cities, and a barracks-equivalent wonder should only help
units in cities, but Sun Tzu helps all units. How would you solve this?

I find the 'effect group' solution would rather clever, however. I am not
sure how gen eff solves the mutual exclusion of the power plants
buildings.

  - Per