Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2004:
[Freeciv-Dev] Re: (PR#8754) effects patch
Home

[Freeciv-Dev] Re: (PR#8754) effects patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: vasc@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#8754) effects patch
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Mon, 17 May 2004 09:15:58 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

Vasco Alexandre da Silva Costa wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >
> 
>>[per@xxxxxxxxxxx - Mon May 17 12:47:48 2004]:
>>
>>This patch is very neat, and it is also a lot shorter than both gen eff
>>and gen impr. Still, not everything is obvious, so please add function
>>comments to the patch as soon as possible.
> 
> Which parts do you find hardest to understand? I can comment those
> better. I only added a general comment at the top of the file.

What all these patches need is explanation of the design.  This should 
be added to doc/HACKING.  But nobody seems willing or able to do this.

jason




[Prev in Thread] Current Thread [Next in Thread]