Complete.Org: Mailing Lists: Archives: freeciv-dev: May 2004:
[Freeciv-Dev] Re: (PR#8754) effects patch (2)
Home

[Freeciv-Dev] Re: (PR#8754) effects patch (2)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: vasc@xxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#8754) effects patch (2)
From: "Per Inge Mathisen" <per@xxxxxxxxxxx>
Date: Mon, 17 May 2004 06:35:40 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8754 >

The patch uses city_affected_by_wonder() heavily, but this function is
still all hardcoded. I assume the intention is to reuse the equiv_range
here instead of the hardcoding, and generalizing this function using the
game.global_wonders array and equiv_range info should be pretty easy. This
redefines equiv_range slightly, which should be documented at least, but I
fail to see any sanity in equiv_range _not_ being equal to the wonder's
effective range. That is, since the eff patch cannot by design have
differently ranged effects in one wonder anyway.

  - Per




[Prev in Thread] Current Thread [Next in Thread]