[Freeciv-Dev] Re: (PR#6979) too long translated string causes client crash

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6979 >

Le lun 17/05/2004 à 18:33, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=6979 >
> 
> Marcelo Burda wrote:
> 
> > with LANG=fr_FR@Euro in gtk-2 client only it crash all the time
> > after executing the start command at server 
> > 
> > In ddd.
> > Program received signal SIGABRT, Aborted.
> > [Switching to Thread 16384 (LWP 2525)]
> > 0x4064ccc1 in kill () from /lib/libc.so.6
> > (gdb) frame 6
> > #6  0x080c81dd in check_strlen (str=0x8521848 "Société de commerce de
> > A. Smith", len=135475168, errmsg=0x8132fe0 "Translated name is too long,
> > truncating: %s") at shared.c:608
> > (gdb) frame 0
> > 
> > i am not sure wath you need, i use gdb(under ddd) or valagrin but if you
> > like say me what command i need to make a best backtrace a can make it.
> > see attached file
> 
> It doesn't happen with the current CVS becuase the name has been 
> shortened to "Ste de commerce...".  However by editing the .po file I 
> can get the crash.  Yay.
after this mail i make a rm -R of my cvs repository then i get a full
load, this bug still in the current cvs!
> 
> So as I said this is a problem with the buffer size.  Why is 
> MAX_LEN_NAME used here?  There is no possibility for abuse or error just 
> by using a strdup'd buffer.
> 
> jason
-- 
 . /  .     '    ,    .      (*)   '        `     '      `    .    
  |    ,  |   `     ,     .      ,   '  Marcelo Julián Burda      .
 /  '     \     `     \@_     '      .        '      `        '    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~