[Freeciv-Dev] Re: (PR#8627) best overview for iso-maps

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8627 >

Le jeu 06/05/2004 à 23:11, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8627 >
> 
...
> >>I think the correct solution is just to draw the whole overview canvas 
> >>black before redrawing it.  Then those tiles will show up black by 
> >>default unless it gets drawn over.
> > 
> > the original code make black all!!
> > that is i get in my screan !!!(probably best as gray but for me black is
> > ok)
> 
> No.  You can see in refresh_overview_canvas it doesn't all get drawn 
> black.  When we iterate over an unknown tile we draw that tile black, 
> which is why it all starts out as black.  But unused portions of the 
> overview (like the zig-zag areas in !TF_WRAPX maps) don't get drawn at all.
> 
...
> jason
see the code (original)
 void set_overview_dimensions(int width, int height)
{
  overview.width = OVERVIEW_TILE_WIDTH * width;
  overview.height = OVERVIEW_TILE_HEIGHT * height;

  if (overview.store) {
    canvas_free(overview.store);
  }
  overview.store = canvas_create(overview.width, overview.height);
  canvas_put_rectangle(overview.store, COLOR_STD_BLACK,
                       0, 0, overview.width, overview.height);
  update_map_canvas_scrollbars_size();

  /* Call gui specific function. */
  map_size_changed();
}
At begin all is black
the zigzag zone are out of natural coordinated and never will changed!
(the problems you was see is no more and was related to the hard coded
wrapx ot the half tiles. this is now corrected) 
-- 
 . /  .     '    ,    .      (*)   '        `     '      `    .    
  |    ,  |   `     ,     .      ,   '  Marcelo Julián Burda      .
 /  '     \     `     \@_     '      .        '      `        '    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~