[Freeciv-Dev] Re: (PR#8632) Easy way to set map size with auto ratios (seteables if desired)

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8632 >

Le mer 05/05/2004 à 19:37, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8632 >
> 
> Marcelo Burda wrote:
> 
> > +    int size_max = MAP_MAX_LINEAR_SIZE / MAX(Xratio, Yratio * iso) / 2;
> > +    int size_min = MAP_MIN_LINEAR_SIZE / MIN(Xratio, Yratio * iso) / 2;
> > +    if (size < size_min) { size = size_min; };
> > +    if (size > size_max) { size = size_max; };
> > +    /* sanity check for extreme map.ratio 
> > +    (as 9:1 or 1:9 (1:18 IN ISO!) and extreme map.size as (2 or 20)*/
> > +    assert(size_min <= size_max);
> 
> I'm not sure this check works.  The size restriction is in _map_ 
> coordinates whereas these calculations seem to be done in native 
> coordinates.
> 
> jason
Hi,
your are right, latter in the code you can see:
+  /* sanity chek for iso map coordinates */
+  if (topo_has_flag(TF_ISO) &&
+      (MAX(map.xsize + map.ysize / 2, map.xsize / 2 + map.ysize) + 1
+      > MAP_MAX_LINEAR_SIZE)) {      /* make a more litle map if
possible */
+    assert(base_size > 0.1);
+    setmapratio2(base_size - 0.1, Xratio, Yratio);
+    return;
for the map coordiantes check in iso..
this is posible for extreme ratios but it is never posible for less
than  2:1 ratios.
Marcelo