[Freeciv-Dev] Re: (PR#6585) Delta version 5

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

On Fri, Oct 24, 2003 at 04:54:04AM -0700, Per I. Mathisen wrote:
> 
> On Tue, 21 Oct 2003, Raimar Falke wrote:
> >  - the numbers for the packets. I said before that this is a
> >  legacy. This isn't true. These numbers are needed so that if you
> >  safely reorder the packets. Note however that you SHOULD not reorder
> >  the fields of the individual packets.
> 
> Why would you reorder the packets?

Because you may want them in alphabetically order or ordered in groups
(unit packets, city packet, ...).

> > The negotiating of compression at runtime is a nasty issue. We have
> > the following possibilities:
> >  - no compression (delta alone will reduce the bandwidth)
> >  - always compression (this makes zlib a dependency)
> 
> Either of these are fine with me. Can compression be made a separate
> patch?

Yes. But I don't see the reason. We should decide this now (next IRC
meeting). Then we act upon the decision.

> > The second still open problem is capabilities. delta5 doesn't support
> > this. The solution will be to add another flag to the fields:
> >  TEAM team; cap(teams)
> > meaning that the field "team" is only read and written if the
> > capability "teams" is present. There is no need to remove fields. Note
> > that this solution will not allow the setting of default values.
> 
> Are default values really necessary, anyway?

Yes.

> What is server/xyzhand_gen.h?

Prototypes of handling functions which doesn't fit into any of the
other categories.

> As usual, I am highly skeptical of adding a lot of new files. Files
> like server/plrhand_gen.h, server/unithand_gen.h etc should be
> removed in favour of one big include.

Ok.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Just because you put a flag on the moon doesn't make it yours, it just
  puts a hole in the moon."