Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2003:
[Freeciv-Dev] Re: (PR#6585) Delta version 5
Home

[Freeciv-Dev] Re: (PR#6585) Delta version 5

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: i-freeciv-lists@xxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#6585) Delta version 5
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Fri, 24 Oct 2003 05:17:23 -0700
Reply-to: rt@xxxxxxxxxxxxxx

The generate_packets.py python script is too ugly.

I suspect it does too much, but I am unable to read it to figure out if
this is the case or no. I suspect it tries to cater to too many expections
and kludges. Instead, these kludges should be straightened out and
removed.

It does not conform to freeciv style guide, to the extent that this would
apply. This it should.

It lacks comments. This is critical.

  - Per




[Prev in Thread] Current Thread [Next in Thread]