[Freeciv-Dev] Re: (PR#5378) Diplomacy information in map middle-click

["Daniel L Speyer" <dspeyer@xxxxxxxxxxx>]

OK, I tried to write the generalized popup patch we discussed, but ran 
into a major problem, possibly the reason that it this wasn't done 
before.  *Translation is gui-dependant.*  Tis routine is full of strings 
that need t be translated, but I can't do that in a general way.  I 
suppose it would be possible to pass the strings as an argument from the 
gui-specific code, but that's rather hideous.

If no one can suggest a general way to do translations, then I think we 
have to give up on the general patch and just commit the one I 
originally wrote.  It's too bad -- that code *ought* to be unified.

--Daniel Speyer

Gregory Berkolaiko wrote:

>On Sun, 24 Aug 2003, Daniel L Speyer wrote:
>
>  
>
>>The real solution is clearly to make a char* get_popup_info(int x, int 
>>y) function in mapctrl_common and have the various GUIs call it.  I'm 
>>reluctant to mess with the GUIs I don't know (especially win32 and mui 
>>which I can't test) but I might be able to do it. 
>>    
>>
>
>Please do.
>
>  
>
>>In any case, I don't 
>>see a reason for the adding-diplomacy-info patch to wait for the 
>>commonizing-popup-info patch, which I'll work on if I get a chance.
>>    
>>
>
>I think I will wait for your get_popup_info patch.  Why commit a 
>half-solution when you will be working on a full one?
>
>G.
>
>
>
>  
>