[Freeciv-Dev] Re: (PR#5378) Diplomacy information in map middle-click

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

On Thu, 11 Sep 2003, Gregory Berkolaiko wrote:

> Hi Daniel,
>
> Sorry about the delay in reply, I was busy and not around the computer
> much anyway.  There are few problems with the patch:
>
> 1. It doesn't apply anymore (sorry again).
>
> 2. Please do the spacing according to the agreed style, e.g. in
> +    while(1){
> +      char *end = strchr(content, '\n');
> +      if (end){
> +       *end=0;
>
> it should be "while (1) {",
> "if (end) {"
> and an extra space before *end and spaces around "=".

I also think it should be: *end='\0';
This is a pointer to char. Looks cleaner this way.

> A patch should be committable without maintainers having to go through
> fixing style.  It wastes their time and introduces more delays.  Please
> read the CodingStyle again and make sure you comply to it.
>
> 3. Can you add more comments please.  For example what you do in Xaw is
> not immediately obvious.

Yeah that one also got me thinking for a bit until I understood it was
necessary to remove the ending newline.

> Best wishes,
> G.
>
> On Thu, 4 Sep 2003, Daniel L Speyer wrote:
>
> > Here's the fixed version.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa