[Freeciv-Dev] Re: freeciv coding style

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Thu, 11 Sep 2003, Jason Short wrote:

> Gregory Berkolaiko wrote:
> 
> > A patch should be committable without maintainers having to go through 
> > fixing style.  It wastes their time and introduces more delays.  Please 
> > read the CodingStyle again and make sure you comply to it.
> 
> In general I agree; however, this may depend on the maintainer.  I often 
> go through and fix style and add comments when applying patches.
> 
> IMO the maintainers should be more rigorous about making sure code is 
> commented.  Having someone other than the patch author write the 
> comments will most likely make them clearer IMO.

Yes, it is always possible to improve patch with a good comment or two, 
and such practice should be encouraged.  However, a patch should be 
committable as it is.