[Freeciv-Dev] Re: (PR#1870) FreecivAC: borders patch

["Rafa³ Bursig" <bursig@xxxxxxxxx>]

Dnia 2003.07.03 14:54, Ben Webb napisaÅ?(a):
> On Thu, Jul 03, 2003 at 04:21:58AM -0700, Rafa� Bursig wrote:
> > There should be new border field in struct city and this variable
> > should be used with border calculation. The game.border parm. 
> should be
> > only max reange limit. This will help us add "culture" effect for
> > civIII ruleset.
> 
> There's no point in adding such a field until someone writes the code
> to use it. I've not played CivIII, so don't know how culture works. 
> If it's just a simple function of the city size, it could probably 
> more easily just be calculated each time.
> 
Basicaly culture power of city is border range of this city. In this 
case each city have different border size.


> > I don't like div to land and ocean cities with border calculation.
> In this way when you city is build on coast your worker can't work on
> > enemy or neutral ocean terrain becouse it is outside your terrians
> 
> Not true: you are only prohibited from working in enemy territory.
> Anybody can work neutral tiles.
> 
And this is wrong your workers should work only on your territory.

Allowing work on neutral is only hack becouse many times borders don't 
claim city ocean tiles.

> > (Current borders don't attach coast city terrains).
> 
> I don't know what you mean here. Currently, cities claim all adjacent
> tiles, plus land tiles on the same continent up to game.borders
> distance, so coastal cities will claim ocean tiles.
> 
But city ocean tiles are outside borders and this is wrong becouse it 
is you territory.

> > Another problem that you have with continent/land limit are ocean
> lakes and dettection it (in this case IMHO current code is poor).
> 
> This has been discussed already - Ross's solution seems the most
> sensible to me. Your screenshots merely demonstrate the same 
> behaviour that Christian and Per have already commented on.
> 
but you still must make those checks

> > I like simple solution that all in border/culture range is your > 
> land no matter that this is land or ocean. In this case you don't > > 
> need made any ugly hack to detect all cases and should nice work
> > with ocean cities.
> 
> Are you suggesting that land cities should claim territory on
> different continents, if they are close enough? The current code 
> doesn't do this.
> 
Are you sure look to attach !

What is wrong when border will claim other continent ?
What is when coast city can work on other continent ?, Those tiles 
aren't yours ?

What about ocean city that was build near land you made different code 
for that or simple lands terrains wont be yours ?

Simple when there is ownership conflic of tile, the city on the same 
continent should win ownership but that all.

Simple rule that you own all terrains in border range will reduce may 
problems , save resources and IMHO is easy to implement.

Rafal