[Freeciv-Dev] Re: [FreeCiv-Cvs] per: Preparation patch for player authentication. In...

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Wed, Apr 09, 2003 at 10:03:21AM -0500, Mike Kaufman wrote:
> On Wed, Apr 09, 2003 at 08:40:35AM +0200, Raimar Falke wrote:
> > On Tue, Apr 08, 2003 at 01:41:00PM -0700, freeciv@xxxxxxxxxxxxxxxxxxx wrote:
> > > This is an automated notification of a change to freeciv cvs, 
> > > on Tue Apr  8 13:36:10 PDT 2003 = Tue Apr  8 20:36:10 2003 (GMT)
> > > by Per I. Mathisen <per@xxxxxxxxxxx>
> > > 
> > > ---- Files affected:
> > > 
> > > freeciv/common game.c player.c player.h
> > > freeciv/server connecthand.c connecthand.h gamehand.c handchat.c 
> > > plrhand.c srv_main.c stdinhand.c
> > > 
> > > ---- Log message:
> > >       Tag: HEAD
> > > 
> > > Preparation patch for player authentication. Introduces a new command 
> > > /take to take command over a player.
> > 
> > I haven't followed this thread closely and this message isn't very
> > helpful. So can you please write in more detail what this patch does?
> 
> in a nushell, you no longer _have_ to connect to a serve with a specific
> username to take control of a specific player. 
> 
> If you do, then as before, you will take control of that player. 
> 
> But if you don't then you will be sent to a staging area (where everybody
> is during pregame). Here you can execute commands (if you have the
> cmdlevel), but you don't get any player packets because your connection isn't
> attached to any player. If you want to play, you do a '/take <playername>'
> and you will be attached to that player.
> 
> This is preparation for authentication (you don't get to login as just
> anybody since usernames are password protected).
> 
> here's a quick example:
> 
> orpheus:~/civ/cvs % ser
> This is the server for Freeciv version 1.14.1-devel
> You can learn a lot about Freeciv at http://www.freeciv.org/
> 2: Now accepting new client connections.
> 
> For introductory help, type 'help'.
> > 
> 2: Connection request from kaufman from localhost.localdomain
> 2: c1 has client version 1.14.1-devel
> 2: kaufman has connected from localhost.localdomain.
> > li
> List of players:
> ------------------------------------------------------------------------------
> noname (username kaufman, Human) 1 connection:
>   kaufman from localhost.localdomain (command access level ctrl),
> bufsize=40kb
> ------------------------------------------------------------------------------
> > create Foo
> > create Bob
> > li
> List of players:
> ------------------------------------------------------------------------------
> noname (username kaufman, Human) 1 connection:
>   kaufman from localhost.localdomain (command access level ctrl),bufsize=40kb
> Foo (username Unassigned, AI, difficulty level easy)
> Bob (username Unassigned, AI, difficulty level easy)
> ------------------------------------------------------------------------------

> > take kaufman Foo

If I use this command from the client "take" (one argument) is ok. But
at the server (two arguments) it should be "assign" or similar.

> kaufman unconnecting from  noname

"unconnecting"??? Since I don't think this is really an unconnecting
you have to change this. "Connection" and "connecting" are preserved
terms. You don't want to define another meaning for them. Use
"attaching" for example.

> removing noname [0]

Where does this "[0]" comes from.

> kaufman now controls Foo
> > li
> List of players:
> ------------------------------------------------------------------------------
> Foo (username kaufman, Human) 1 connection:
>   kaufman from localhost.localdomain (command access level ctrl),bufsize=40kb
> Bob (username Unassigned, AI, difficulty level easy)
> ------------------------------------------------------------------------------
> > remove Foo

> 2: Removing player Foo.
> Removed player Foo from the game.

One is enough.

> > li
> List of players:
> ------------------------------------------------------------------------------
> Bob (username Unassigned, AI, difficulty level easy)
> ------------------------------------------------------------------------------

This situation is similar to the start (after you connected). In both
cases no player was assigned to the human player. But the outputs
differ. At the start kaufman was listed here.

> > li connections
> List of connections to server:
> ------------------------------------------------------------------------------
> kaufman from localhost.localdomain command access level ctrl
> ------------------------------------------------------------------------------
> > take kaufman Bob
> kaufman now controls Bob
> > li
> List of players:
> ------------------------------------------------------------------------------
> Bob (username kaufman, Human) 1 connection:
>   kaufman from localhost.localdomain (command access level ctrl),bufsize=40kb
> ------------------------------------------------------------------------------
> > quit     
> Goodbye.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  "Heuer's Law: Any feature is a bug unless it can be turned off."