[Freeciv-Dev] Re: (PR#3746) explosion sprites are loaded twice

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Fri, Mar 21, 2003 at 12:17:17AM -0800, Jason Short wrote:
> 
> [jdorje - Tue Mar 18 06:32:36 2003]:
> 
> > One thing I just noticed about the new sprite loading code is that the
> > unit explosion sprites are loaded twice - once when counting how many
> > explosion sprites there are, and a second time when putting them into an
> > array.  This just means there is an extra reference to the sprite, which
> > means if unload_sprite were ever called (outside of free_all_sprites) on
> > these sprites we probably wouldn't end up releasing the pixmap
> immediately.
> > 
> > The attached patch is a poor solution to this problem.
> 
> The attached patch is a better solution.

I would like to apply this patch. However I think that the name
"check_sprite" is too general. Can we rename it to "sprite_exists"? If
yes you don't need to send a new patch.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Python is executable pseudocode. Perl is executable line noise"
    -- Bruce Eckel