Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2003:
[Freeciv-Dev] Re: (PR#3746) explosion sprites are loaded twice
Home

[Freeciv-Dev] Re: (PR#3746) explosion sprites are loaded twice

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients:;
Subject: [Freeciv-Dev] Re: (PR#3746) explosion sprites are loaded twice
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 21 Mar 2003 11:43:53 -0800
Reply-to: rt@xxxxxxxxxxxxxx

"Rafa????????????????????????????" wrote:
> Dnia 2003.03.21 09:17 Jason Short napisa?(a):
> 
>>[jdorje - Tue Mar 18 06:32:36 2003]:
>>
>>
>>>One thing I just noticed about the new sprite loading code is that
>>
>>the
>>
>>>unit explosion sprites are loaded twice - once when counting how
>>
>>many
>>
>>>explosion sprites there are, and a second time when putting them
>>
>>into an
>>
>>>array.  This just means there is an extra reference to the sprite,
>>
>>which
>>
>>>means if unload_sprite were ever called (outside of
>>
>>free_all_sprites) on
>>
>>>these sprites we probably wouldn't end up releasing the pixmap
>>
>>immediately.
>>
>>>The attached patch is a poor solution to this problem.
>>
>>The attached patch is a better solution.
> 
> It's better that my code but I think real solution should be make in 
> "hash" code.

I don't understand what you mean.

jason




[Prev in Thread] Current Thread [Next in Thread]