[Freeciv-Dev] Re: (PR#2370) Path finding

[Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>]

Quoting Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>:

> On Fri, Feb 21, 2003 at 11:19:13PM +0000, Gregory Berkolaiko wrote:
> > Quoting Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>:
> > 
> > > On Fri, Feb 21, 2003 at 10:58:51PM +0000, Gregory Berkolaiko wrote:
> > > > Quoting Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>:
> > > > 
> > > > > > Give me a problem that requires "known" here and cannot be solved
> by
> > > > > existing
> > > > > > call-backs and then we can negotiate.
> > > > > 
> > > > > This one extra argument is one extra push for the caller. Thats it.
> No
> > > > > other cost. gcc doesn't pop but just adjusts the %esp directly. And
> it
> > > > > has no influence on the called function (if the function doesn't
> use
> > > > > it). I expect that a push is fast. Very fast since you need it
> > > > > everytime you call a function.
> > > > 
> > > > Don't push it on me, man!  Since you are not giving me the example
> > > > that needs it, we will assume that none such exists.
> > > 
> > > That callback were your idea. I have no code which needs this callback
> > > at all.
> > > 
> > > But your point (add it if current code needs it) is mood. This way we
> > > wouldn't have EC, is_pos_dangerous and TM_*_TIME.
> 
> > Not true.  I am not asking for existing code / problem.  I am asking
> > for any (future) situation where we would need this.  And I can give
> > you situations (as you can do yourself) where there is need for EC,
> > is_pos_dangerous and TM_*_TIME.
> 
> That would a situation where depending on the known state of the
> target of the step the MC of the step is changed. Any sane person
> would not attach this to a step but to the tile and so use EC. I agree

Precisely.

I suggest you put your other suggestions / remarks in the code, while we are
waiting for other people to comment.

G.


> that the usage of known is very unlikely.
> 
>       Raimar
> 
> -- 
>  email: rf13@xxxxxxxxxxxxxxxxx
>  "#!/usr/bin/perl -w
>   if ( `date +%w` != 1 ) {
>     die "This script only works on Mondays." ;
>   }"
>     -- from chkars.pl by Cornelius Krasel in de.comp.os.linux.misc
> 
> 
>