[Freeciv-Dev] Re: (PR#3424) New flush code soplited in 2 parts

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Mon, Feb 17, 2003 at 11:53:33AM -0800, Jason Short wrote:
> Raimar Falke wrote:
> > On Thu, Feb 13, 2003 at 04:50:59PM -0800, Rafa? Bursig wrote:
> > 
> > why can't the non-sdl guis also do the deferred flushing? I.e. save
> > the info and only flush at flush_rects just like gui-sdl? This would
> > make the code more homogeneous.
> 
> Works for me.  However there are some drawing bugs (see 2982) that may 
> cause problems for the flushing method. Also it takes a lot of code to 
> do in independently for each GUI; I had thought to introduce a set of 
> common functions to do this in a second patch (if it is done at all).
> 
> However, the situation with update_map_canvas_visible (where we don't 
> call dirty_all even though it seems we should) makes me think 

> that all clients should do the flush-buffering

Pro:
 - since the flushs get defered this adds the _possibility_ to merge
 flushs
 - makes it the same for all clients (and gui-sdl needs it, so we
 can't do it the other way around)

Con:
 - ??

Seems pretty clear to me.

> My next question, then, is: does this flush-buffering code need to
> go into the GUI, or can there just be one implementation in
> mapview_common?

dirty_rectangle
dirty_all
flush_dirty

can all be done with in common code. The hook here would be
flush_region with the same parameter as the current flush_mapcanvas.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Tank: So what do you need? Besides a miracle.
  Neo: Guns. Lots of guns.
    -- From The Matrix