[Freeciv-Dev] Re: (PR#3424) New flush code soplited in 2 parts

["Raimar Falke" <rf13@xxxxxxxxxxxxxxxxx>]

On Thu, Feb 13, 2003 at 04:50:59PM -0800, Rafa³ Bursig wrote:
> 
> Hi
> 
> Next step to new buffer code in SDLClient.
> 
> This is secound version of New Flush code.
> 
> add_to_flush( x , y, w , h ) - save redrawed arrea in rect array.
> flush_rects(void) - flush stored rects in one call.
> add_all_to_flush(void) - save entire screen to flush and block adding 
> new rect to array untill flush_rects() funct is call.
> 
> For All Clients ( exept SDLClient ) this give the same current 
> functionality becouse
> add_to_flush( x , y, w , h ) function call flush_mapcanvas(x , y, w , 
> h) and
> flush_rects(void) , add_all_to_flush(void) are empty.
> 
> In future Client Maintainers can make own flush code based on this 
> functions.
> 
> But current SDLClient can use additonnal flush extensions.
> 
> this code was split on two sub-patches :
> 1) add new API functions and set basic functionality of this code.
> 2) change all call of refresh_tile_mapcanvas(map_x, mao_y, TRUE) to
>      refresh_tile_mapcanvas(map_x, map_y, FALSE).
> 
> Secound wouldn't have any influenceon other clients becouse :
> TRUE -> call flush_mapcanvas(x , y, w , h).
> FALSE -> call add_to_flush( x , y, w , h ).

Naming: all three function should have the same prefix
Coding-Style: read the guide. 
 +void add_to_flush( int canvas_x , int canvas_y ,
                    ^            ^  remove these

Purpose: why do you remove the final flush_mapcanvas in
update_map_canvas_visible only to add a call to flush_rects after the
call of update_map_canvas_visible in control.c? Won't adding "bool
write_to_screen" to update_map_canvas_visible be better here?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Programming today is a race between software engineers striving to
  build bigger and better idiot-proof programs, and the Universe trying
  to produce bigger and better idiots. So far, the Universe is winning."
    -- Rich Cook