[Freeciv-Dev] Re: (PR#3450) square_iterate and unreal positions

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Raimar Falke wrote:
> On Mon, Feb 17, 2003 at 12:08:37AM -0800, Jason Short wrote:
> 
>>For some reason square_iterate calls CHECK_MAP_POS on its center tile. 
>>This is a problem since it only shows up in debug mode and is not 
>>obvious to the programmer.  And I really don't know why it does that (I 
>>wrote the code for it, some time ago).
>>
>>This CHECK_MAP_POS should probably be removed.
> 
> 
> Why? It is a check which tests if the args given to square_iterate are
> valid. We have the same checks in other functions/macros likesame_pos.

The definition of 'valid' may change.  In one situation, it is okay for 
the center of the square to be an unreal position.  In this case it is 
the (center_x+1,center_y+1) tile that determines the location of the square.

This is an untraditional usage of square_iterate; it is also reasonable 
to say square_iterate should not be used in this way.  But in that case 
we have the problem that developers are likely to misuse square_iterate.

jason