[Freeciv-Dev] Re: (PR#2922) Re: (PR#2924) OK. the reorg patch has a bug. Help from a client expert?

["Raimar Falke via RT" <rt@xxxxxxxxxxxxxx>]

> > Change 
> > 
> >   For the flags and for the flags only: we crop the sprite further
> >   (gui-gtk/plrdlg.c:build_flag) by calling
> >   gui-gtk/graphics.c:sprite_get_bounding_box and
> >   gui-gtk/graphics.c:crop_sprite. And yes this is isn't what I would
> >   call nice.
> > 
> > to
> > 
> >   For the flags and for the flags only which are shown in the player
> >   report: we crop the sprite further
> >   (gui-gtk/plrdlg.c:build_flag) by calling
> >   gui-gtk/graphics.c:sprite_get_bounding_box and
> >   gui-gtk/graphics.c:crop_sprite. And yes this is isn't what I would
> >   call nice.
> > 
> > Sorry about this.
> 
> But this cropping has to be done internally to gui-gtk, right?  The 
> original flags PNGs shouldn't be cropped.

Yes. This is what I wanted to express.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Understanding is a three-edged sword; 
  your side, their side, and the truth."
    -- a well-known Vorlon