[Freeciv-Dev] Re: (PR#2922) Re: (PR#2924) OK. the reorg patch has a bug. Help from a client expert?

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

Raimar Falke via RT wrote:
> On Mon, Jan 27, 2003 at 09:25:18PM -0800, esr@xxxxxxxxxxx via RT wrote:
> 
>>esr@xxxxxxxxxxx via RT <rt@xxxxxxxxxxxxxx>:
>>
>>>I'll crock my conversion script so it doesn't autocrop anything that 
>>>is not a flag.  This is easy and fast and will work around the symptom.  But
>>>you're right; this should really be fixed at a deeper level.
>>>
>>>The problem with the trident tileset is different; I forgot to strip off
>>>some .spec suffixes in the filename.  I'll ship a revised patch that
>>>fixes these bugs.
>>
>>I applied those fixes, and found a typo in my trident_shields patch.
>>Current state of play:
>>
>>1. trident, trident_shield and isotrident tilesets all load OK.
>>
>>2. All icons look properly placed now, *except*...
> 
> 
>>3. ...flags in isotrident are still being painted above and to left of
>>where they ought to be.  They're correctly placed in the non-iso case.
> 
> 
> Change 
> 
>   For the flags and for the flags only: we crop the sprite further
>   (gui-gtk/plrdlg.c:build_flag) by calling
>   gui-gtk/graphics.c:sprite_get_bounding_box and
>   gui-gtk/graphics.c:crop_sprite. And yes this is isn't what I would
>   call nice.
> 
> to
> 
>   For the flags and for the flags only which are shown in the player
>   report: we crop the sprite further
>   (gui-gtk/plrdlg.c:build_flag) by calling
>   gui-gtk/graphics.c:sprite_get_bounding_box and
>   gui-gtk/graphics.c:crop_sprite. And yes this is isn't what I would
>   call nice.
> 
> Sorry about this.

But this cropping has to be done internally to gui-gtk, right?  The 
original flags PNGs shouldn't be cropped.

jason