[Freeciv-Dev] Re: (PR#2924) OK. the reorg patch has a bug. Help from a client expert?

["Jason Short via RT" <rt@xxxxxxxxxxxxxx>]

esr@xxxxxxxxxxx via RT wrote:
> The reorg patch I posted a few hours ago turns out to have a silly bug
> that I didn't notice soon enough.  Units and resource icons (but not
> terrain tiles) are now displayed somewhat up and to the left of where they
> should be.
> 
> There is some pair of constant offsets that the drawing routines are not
> seeing any more.  Do any of the client maintainers have a guess what this
> might be?
> 
> This was hard to spot because the terrain looks so good...

The file graphics/isotrident/terrain1/tx.village.png is incorrect. 
Looking at isotrident/terrain1 I don't see how this output could have 
been reached.  But the end result is that tx.village for isotrident 
seems to have copied that of trident.

There is a one-pixel boundary between grid elements if is_pixel_border 
is set.  For instance in tilespec.c:

      x1 = x_top_left + column * dx + (is_pixel_border ? column : 0);
      y1 = y_top_left + row * dy + (is_pixel_border ? row : 0);

Perhaps you are not taking this into account?


A bigger problem is that the new graphics are 8x larger than the old 
ones.  On my computer the minimum block size is 4k, which is what causes 
this (most files are 1k in size).  But it doesn't seem good...

jason