[Freeciv-Dev] (PR#2408) Problem with diagonal roads and rails

["Guest via RT" <rt@xxxxxxxxxxxxxx>]

[jdorje - Wed Dec 11 04:27:24 2002]:
> Attached patch should handle this for roads and rails, for iso and
> non-iso view.  It also won't abort if a tileset doesn't have support (so
> it should be both forward- and backward-compatible).
> 
> No new graphics or specfiles are supplied.  Thue's original patch
> included trident rail support.
> 
> jason

You shouldn't draw the road corners if the connection is a railroad. So
in fill_road_corner_sprites the road code part need to check that both
adjacent tiles don't contain railroad. Only then should you it count for
a road.

You also need to split the fill_road_corner_sprites function up into 2.
As it is now there is a problem when a diagonal road crosses a diagonal
rail. In that case the road corners need to be drawn below the rail
diagonals, but the rail corners need to be drawn above the road
diagonals. The solution would be to make fill_road_corner_sprites and
put it just before the rail drawing, and make fill_rail_corner_sprites
and put that just after the rail drawing.

-Thue (who was too lazy to actually code this.)