[Freeciv-Dev] Re: [Freeciv] rfc: autoattack

["Per I. Mathisen" <per@xxxxxxxxxxx>]

On Sun, 17 Nov 2002, Thomas Strub wrote:
> I use the key "k" for the autoattac"k".
> Think only a sprite for the "k" is missing.

Wow, that was fast.

Some short comments so far (haven't tested it yet):
 - Please remove the old autoattack code.
 - Reuse the "A" key and sprite which the old autoattack code used. (This
conflicts with A for autosettlers, but that doesn't matter, since by the
time we have a modpack with military settlers, I bet Raimar has already
moved autosettlers to the client anyway.)
 - ACTIVITY_SERVER_AUTO_ATTACK -> ACTIVITY_AUTO_ATTACK
 - Why are you checking in a 3 square radius? My suggestion was adjacent
units only. Doing it over a larger distance has many pitfalls and may not
be better (harder to know what it does, harder to trust).
 - If you only don't do 3 square radius, then don't use do_unit_goto(),
use handle_unit_move_request() instead, as goto is overkill when you only
are to move one square. This should simply a lot of the other code too.

  - Per