[Freeciv-Dev] Re: [Patch] freeze/thaw functions

[Raimar Falke <rf13@xxxxxxxxxxxxxxxxx>]

On Mon, Jun 24, 2002 at 12:01:10AM +0100, Vasco Alexandre Da Silva Costa wrote:
> On Sun, 23 Jun 2002, Raimar Falke wrote:
> 
> > On Tue, Jun 11, 2002 at 04:21:59PM +0200, Christian Knoke wrote:
> > > On Mon, Jun 10, 2002 at 11:00:26PM +0200, Christian Knoke wrote:
> > > > On Mon, Jun 10, 2002 at 09:02:28PM +0200, Raimar Falke wrote:
> > > > >
> > > > > [ This patch supersedes the disable_cityrep_update_till patches. ]
> > > > >
> > > > > This is a no longer a proof-of-concept patch but a real one ;)
> > > >
> > > > This patch, apllied (cleanly) to 12 hours old CVS, has a nice side
> > > > effect: It pops up the messages window, after a global change is done,
> > > > as well as when you disconnect the client. When you start up, it pops
> > > > up the city report (sometimes).
> > > >
> > > > Maybe a cvs difference?
> > >
> > > I tried it again with todays cvs. It apllied, but not cleanly.
> > > It compiled and ran.
> > >
> > > It still opens the message window occasionnally, e.g. when
> > > I change the CMA preset in the city window. Funny.
> >
> > New version attached. Changes:
> >  - take care of all GUIs (this reduce the number of code lines which
> >  gets added from 346 to 44)
> >  - take care of the bug above (only popup meswin if a real change
> >  happend)
> >
> > Please test.
> 
> I still have problems with the message window poping up. E.g. after i do a
> disconnect.

Fixed. I just missed a line.

> BTW i changed chatline_common.c to use struct astring and less calls to
> strlen() and strcat(). This means it should be much faster as it saves
> quite a few string traversals, and possibly uses less reallocs(). Of
> course this is more than likely not the main bottleneck in the client
> updates, but what the heck...
> 
> I hope i didn't add any bugs :-)

Doesn't looks so.

A third change I made is to move the call of reports_freeze from
new_turn to start_turn. This freeze the reports till the server AI
finishes all the start turn activities.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "SIGDANGER - The System is likely to crash soon"

reports_freeze_till4.diff.gz
Description: GNU Zip compressed data