[Freeciv-Dev] Re: Wish list Items

[Ben Webb <ben@xxxxxxxxxxxxxxxxxxxxxx>]

On Fri, 8 Mar 2002, Mike Kaufman wrote:

> another way to go would be to change the behavior of "civstyle" server option.
> Current this is a binary options set to civ2 style. If you feel that
> freeciv isn't quite true enough to civ2, make the option trinary with the
> default as 0, (freeciv rules). Then, for example, you could do something
> like we do in do_apollo(): if(game.civstyle == 2) { do Leonardo's
> differently; } (On the other hand, currently, we are trying to generalize
> improvements, so it may be better to do this with improvement effect flags)

        Eurgh. I have nightmares about civstyle. ;) Generalised 
improvements are complete, with the exception of AI support, so if you 
just want to tweak the behaviour a little bit, I'd recommend you play with 
the effect flags (after applying the impr-gen patch from 
http://freecivac.sf.net/, of course). The AI will then do "the wrong 
thing" obviously, since it'll be using its idea of what the building is 
supposed to do, but it already subtly does the "wrong" thing in my cases 
already anyway, or so I'm told.

BTW, I get rid of do_apollo entirely with the impr-gen patch. It's evil.

> Ben: I don't even know the difference between new and old behavior of
> Leonardo.

        That makes two of us then! The current behaviour is to upgrade 
_one_ unit per game turn, to the _most advanced_ type. impr-gen also adds 
effects for upgrading _all_ units, and/or stepping through each 
intermediate type. I _think_ the "old" behaviour is to upgrade all units 
each turn.

> Is it possible to change effect flags to change behavior

        But of course; that's kind of the point. ;) In this case, you'd 
just replace the "Upgrade_One_Leap" effect currently used by Leonardo with 
"Upgrade_All_Leap". See data/default/buildings.ruleset.

> and is it possible to do this with the current codebase?

        Nope. You need to apply the impr-gen patch first, or use 
FreecivAC. No, I can't explain why it's not in CVS yet. ;)

        Ben
-- 
ben@xxxxxxxxxxxxxxxxxxxxxx           http://bellatrix.pcl.ox.ac.uk/~ben/
"You know my methods, Watson."
        - 'The Crooked Man', Sir Arthur Conan Doyle