[Freeciv-Dev] Re: warnings when compiling with NDEBUG (PR#1216)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Feb 04, 2002 at 04:12:53PM +0100, Reinier Post wrote:
> On Mon, Feb 04, 2002 at 10:23:39AM +0000, Ben Webb wrote:
> > On Mon, 4 Feb 2002, Reinier Post wrote:
> > 
> > > On Sun, Feb 03, 2002 at 09:18:42PM +0100, Raimar Falke wrote:
> > > > NDEBUG disables assert which should make freeciv faster. I'm not sure
> > > > how much. So I don't see the benefit of removing it.
> > > 
> > > The name is confusing (it appears to mean !DEBUG).
> > 
> >     Not much we can do about that, as (according to the assert 
> > manpage) NDEBUG is defined to have this assert-disabling behaviour in the 
> > ANSI C spec.
> > 
> >     Ben
> 
> Thanks.  I didn't even know NDEBUG is standard ANSI C (see
> 
>   http://www.lysator.liu.se/c/rat/d2.html
> 

> ) now I wonder if anything is assumed about DEBUG in ANSI C.

$ grep DEBUG n2620.txt
       NDEBUG.  If used, a header shall be included outside of  any
               NDEBUG
       which is not defined by <assert.h>.  If NDEBUG is defined as
               NDEBUG
       NDEBUG macro, 7.2

> Searching for that, I found
> 
>   http://users.powernet.co.uk/eton/unleashed/errata/ech07.html
> 
> which describes the problem exactly.  Guides such as
> 
>   http://www.dpunkt.de/leseproben/3-932588-67-3/Kapitel%207.pdf
> 
> suggest to use DEBUG for debug levels, which is what Freeciv does.
> 
> So I suppose Freeciv uses NDEBUG and DEBUG in the usual way after all.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Living on earth may be expensive, but it includes an annual free trip
  around the sun.