[Freeciv-Dev] Re: warnings when compiling with NDEBUG (PR#1216)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sun, Feb 03, 2002 at 07:32:31PM +0100, Reinier Post wrote:
> On Sun, Feb 03, 2002 at 12:19:44AM +0100, Raimar Falke wrote:
> 
> > if test "x$enable_debug" = "xyes"; then
> >   test "$cflags_set" = set || CFLAGS="$CFLAGS -g"
> >   CPPFLAGS="$CPPFLAGS -DDEBUG"
> > else
> >   if test "x$enable_debug" = "xno"; then
> >     CPPFLAGS="$CPPFLAGS -DNDEBUG"
> >   fi
> > fi
> > 
> > So yes there can be NDEBUG, <nothing> (the default) and DEBUG.
> 
> Wouldn't it be better to remove NDEBUG, which I've never seen anywhere else,
> and which is an open invitation for testing errors in the first place?

NDEBUG disables assert which should make freeciv faster. I'm not sure
how much. So I don't see the benefit of removing it.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "If at first you don't succeed... well so much for skydiving."