Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2002:
[Freeciv-Dev] Re: warnings when compiling with NDEBUG (PR#1216)
Home

[Freeciv-Dev] Re: warnings when compiling with NDEBUG (PR#1216)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Freeciv-Dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: warnings when compiling with NDEBUG (PR#1216)
From: Reinier Post <rp@xxxxxxxxxx>
Date: Sun, 3 Feb 2002 19:32:31 +0100

On Sun, Feb 03, 2002 at 12:19:44AM +0100, Raimar Falke wrote:

> if test "x$enable_debug" = "xyes"; then
>   test "$cflags_set" = set || CFLAGS="$CFLAGS -g"
>   CPPFLAGS="$CPPFLAGS -DDEBUG"
> else
>   if test "x$enable_debug" = "xno"; then
>     CPPFLAGS="$CPPFLAGS -DNDEBUG"
>   fi
> fi
> 
> So yes there can be NDEBUG, <nothing> (the default) and DEBUG.

Wouldn't it be better to remove NDEBUG, which I've never seen anywhere else,
and which is an open invitation for testing errors in the first place?

>       Raimar

-- 
Reinier


[Prev in Thread] Current Thread [Next in Thread]