[Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)

[Jason Short <vze2zq63@xxxxxxxxxxx>]

Raimar Falke wrote:

> On Wed, Dec 05, 2001 at 04:59:13AM -0800, Raahul Kumar wrote:
> > --- Petr Baudis <pasky@xxxxxxxxxxx> wrote:
> > > Thing I have problem with is:
> > > +     dx = abs(dx), dy = abs(dy);
> > > I think it should be rather
> > > +     dx = abs(dx); dy = abs(dy);
> > > What do you think?
> From the language syntax point of view both version are the same. I
> know that Ross sometimes prefer the , version. It looks like also
> Jason prefer it (Jason: under which conditions?). So I would like to
> add this to the style guide questionnaire:
>
>
>  <some number>
>  This isn't about initialization!
>
> /* A */
>   x = punit->x, y = punit->y;
>
> /* B */
>   x = punit->x;
>   y = punit->y;
>
> Something like
>   x = punit->x; y = punit->y;
> will not work because it will be broken up by indent.
I do not really have a preference.  But I don't find the comma notation 
unreadable at all, and I guess Ross's ways have rubbed off a little.  It 
never really occurred to me that this might be a problem for other people.
jason