[Freeciv-Dev] Re: [PATCH] base_real_map_distance (PR#1049)

[Raahul Kumar <raahul_da_man@xxxxxxxxx>]

--- Petr Baudis <pasky@xxxxxxxxxxx> wrote:
> Hi,
> 
>   sorry I respond to so old mail, however I didn't find the patch which
> just got into CVS here and this is only mail where I discovered this change.
> I just had a look what changed in the code I actually clean, and basically
> following:
> 
> > Index: server/settlers.c
> > ===================================================================
> > RCS file: /home/freeciv/CVS/freeciv/server/settlers.c,v
> > retrieving revision 1.112
> > diff -u -r1.112 settlers.c
> > --- server/settlers.c       2001/10/14 21:02:17     1.112
> > +++ server/settlers.c       2001/11/01 14:09:33
> > @@ -769,8 +769,8 @@
> >    for (i = 0; i < game.nplayers; i++) {
> >      city_list_iterate(game.players[i].cities, pcity) {
> >        if (map_distance(x, y, pcity->x, pcity->y)<=8) {
> > -        dx = xdist(pcity->x, x);
> > -        dy = ydist(pcity->y, y);
> > +   base_real_map_distance(&dx, &dy, pcity->x, pcity->y, x, y);
> > +   dx = abs(dx), dy = abs(dy);
> >     /* these are heuristics... */
> >          if (dx<=5 && dy<5)
> >            return 0;
> 
> Thing I have problem with is:
> +     dx = abs(dx), dy = abs(dy);
> I think it should be rather
> +     dx = abs(dx); dy = abs(dy);
> What do you think?
> 
> Sorry I'm so late, just please take this as an example of that inclusion
> into CVS is best impulse for review ;-).
> 
> -- 

I'd say Jason has been careless. I thought you already mentioned this buglet to
Raimar. Add that punctuation Raimar.

__________________________________________________
Do You Yahoo!?
Buy the perfect holiday gifts at Yahoo! Shopping.
http://shopping.yahoo.com