[Freeciv-Dev] Re: Tech cost patch v8

[Juha Litola <slave@xxxxxxxxxxxx>]

On Fri, Nov 30, 2001 at 07:07:10PM +0100, Raimar Falke wrote:
> On Fri, Nov 30, 2001 at 06:30:10PM +0200, Juha Litola wrote:
> > As there were now additional comment, changes to v7 are few:
> > - integrated num_tech_reqs to precalc_tech_data
> > 
> > I guess this might be ready now.
> 
> Nice guess ;)
But it was wrong as my v9 mail shows. 

> First I want to point out that I will take the freedom to apply some
> style changes. Like changing
> Please tell me if you don't like.
No problem with them.

> Second:
> +      mul = 10 * (players - playerswithtech) / players;
> +      return mul * cost / 10;
> should be rewritten as
>        return ((players - playerswithtech)*cost)/players;
Yes, of course. Why didn't I notice that. Will you make the change
or shall I send the v10.

> Third: the default cases. For the freeciv ruleset you set them to
> tech_cost_style = 1 and tech_leakage = 1. We have to hear comments on
> this. We may for example start with a civ3 ruleset where this is
> activated.
Those were left in as I tested with default.ruleset. Feel free to change
them. I asked opinions about default mode in one mail, but got no
response. Maybe it should be in poll in www.freeciv.org.

--
// Juha Litola

pgpZISZL5AeJC.pgp
Description: PGP signature