[Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 30, 2001 at 05:07:10PM -0500, Jason Dorje Short wrote:
> Gaute B Strokkenes wrote:
> > 
> > On Tue, 30 Oct 2001, gs234@xxxxxxxxx wrote:
> > > On Tue, 30 Oct 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
> > >> On Tue, Oct 30, 2001 at 02:45:01AM +0000, Gaute B Strokkenes wrote:
> > >>>
> > >>> I propose the following:
> > >>
> > >> Ok, but
> > >>
> > >>>  signed short map_get_continent(int x, int y)
> > >>>  {
> > >>> -  if (!normalize_map_pos(&x, &y))
> > >>> +  if (!normalize_map_pos(&x, &y)) /* XXX */
> > >>
> > >> ??
> > >
> > > [snip similar stuff]
> > >
> > >> As stated, we want normal map positions in all cases.
> > >
> > > I didn't check that making it crash here would work.  If someone
> > > else did, then we can remove them here too.
> 
> Yes, it's been checked pretty thoroughly.
> 
> Only two concerns with this patch:
> 
> 1.  The #include <assert.h> might be better placed in map.h, since
> that's where the assertion actually is.

Ack.

> 2.  CHECK_POS should be named CHECK_MAP_POS.

Ack.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  +#if defined(__alpha__) && defined(CONFIG_PCI)
  +       /*
  +        * The meaning of life, the universe, and everything. Plus
  +        * this makes the year come out right.
  +        */
  +       year -= 42;
  +#endif
    -- Patch for 1.3.2 (kernel/time.c) from Marcus Meissner