Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2001:
[Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)
Home

[Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: Gaute B Strokkenes <gs234@xxxxxxxxx>
Cc: jdorje@xxxxxxxxxxxxxxxxxxxxx, freeciv-dev <freeciv-dev@xxxxxxxxxxx>, "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)
From: Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Tue, 30 Oct 2001 17:32:21 +0100
Reply-to: rf13@xxxxxxxxxxxxxxxxxxxxxx

On Tue, Oct 30, 2001 at 04:02:08PM +0000, Gaute B Strokkenes wrote:
> On Tue, 30 Oct 2001, gs234@xxxxxxxxx wrote:
> > On Tue, 30 Oct 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
> >> On Tue, Oct 30, 2001 at 02:45:01AM +0000, Gaute B Strokkenes wrote:
> >>> 
> >>> I propose the following:
> >> 
> >> Ok, but
> >> 
> >>>  signed short map_get_continent(int x, int y)
> >>>  {
> >>> -  if (!normalize_map_pos(&x, &y))
> >>> +  if (!normalize_map_pos(&x, &y)) /* XXX */
> >> 
> >> ??
> > 
> > [snip similar stuff]
> > 
> >> As stated, we want normal map positions in all cases.
> > 
> > I didn't check that making it crash here would work.  If someone
> > else did, then we can remove them here too.

Ok from my side.

Jason? Ross?

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Living on earth may be expensive, but it includes an annual free trip
  around the sun.


[Prev in Thread] Current Thread [Next in Thread]