[Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)

[Jason Dorje Short <vze2zq63@xxxxxxxxxxx>]

Gaute B Strokkenes wrote:
> 
> On Mon, 29 Oct 2001, vze2zq63@xxxxxxxxxxx wrote:

[snip: check_map_pos]

> I see you have changed IS_BORDER_MAP_POS() and map_inx() so that they
> have to take lvalues as arguments.  What's the point?  As pointed out
> elsewhere, you can not reliably repair this sort of damage in the
> arbitrary topologies that you are proposing.

I now agree with you - the overhead of passing lvalues into these macros
is just too high.  We should ditch the possibility of repairing
non-normal coordinates and just be content with searching for bugs.

One other thing: the patch uncovers a bug in map generators 3 and 4. 
The assertion will fail in map generation.  I haven't looked at this too
closely yet.  It seems likely that other bugs will be found as well once
the patch is into CVS.

jason