[Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)

[Jason Dorje Short <vze2zq63@xxxxxxxxxxx>]

Gaute B Strokkenes wrote:
> 
> On Tue, 30 Oct 2001, gs234@xxxxxxxxx wrote:
> > On Tue, 30 Oct 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
> >> On Tue, Oct 30, 2001 at 02:45:01AM +0000, Gaute B Strokkenes wrote:
> >>>
> >>> I propose the following:
> >>
> >> Ok, but
> >>
> >>>  signed short map_get_continent(int x, int y)
> >>>  {
> >>> -  if (!normalize_map_pos(&x, &y))
> >>> +  if (!normalize_map_pos(&x, &y)) /* XXX */
> >>
> >> ??
> >
> > [snip similar stuff]
> >
> >> As stated, we want normal map positions in all cases.
> >
> > I didn't check that making it crash here would work.  If someone
> > else did, then we can remove them here too.

Yes, it's been checked pretty thoroughly.

Only two concerns with this patch:

1.  The #include <assert.h> might be better placed in map.h, since
that's where the assertion actually is.

2.  CHECK_POS should be named CHECK_MAP_POS.

I think there are other positions where normalize_map_pos can be
replaced, but I'd be just as happy to change these later.

jason