[Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)

["Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>]

Apart from the damage the patch is designed to commit, it looks fine.

I'd leave the NDEBUG stuff in as a safety valve so people could compile
and have it fry them slowly, rather than crash in an assert, but this
is more cosmetic user friendliness. A better way would be to put a 
normalize_map_pos() in the safe side - modest PR value.

When he is not updating code spacing, Gaute's coding style is refreshingly
concise.

Cheers,
RossW
=====

At 05:32 PM 01/10/30 +0100, Raimar Falke wrote:
>On Tue, Oct 30, 2001 at 04:02:08PM +0000, Gaute B Strokkenes wrote:
>> On Tue, 30 Oct 2001, gs234@xxxxxxxxx wrote:
>> > On Tue, 30 Oct 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
>> >> On Tue, Oct 30, 2001 at 02:45:01AM +0000, Gaute B Strokkenes wrote:
>
>Ok from my side.
>
>Jason? Ross?
>
>       Raimar
>-- 
> email: rf13@xxxxxxxxxxxxxxxxx
>  Living on earth may be expensive, but it includes an annual free trip
>  around the sun.