Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2001:
[Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)
Home

[Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: jdorje@xxxxxxxxxxxxxxxxxxxxx, freeciv-dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: [PATCH] check_map_pos change (PR#1031)
From: Gaute B Strokkenes <gs234@xxxxxxxxx>
Date: Tue, 30 Oct 2001 16:02:08 +0000

On Tue, 30 Oct 2001, gs234@xxxxxxxxx wrote:
> On Tue, 30 Oct 2001, hawk@xxxxxxxxxxxxxxxxxxxxxxx wrote:
>> On Tue, Oct 30, 2001 at 02:45:01AM +0000, Gaute B Strokkenes wrote:
>>> 
>>> I propose the following:
>> 
>> Ok, but
>> 
>>>  signed short map_get_continent(int x, int y)
>>>  {
>>> -  if (!normalize_map_pos(&x, &y))
>>> +  if (!normalize_map_pos(&x, &y)) /* XXX */
>> 
>> ??
> 
> [snip similar stuff]
> 
>> As stated, we want normal map positions in all cases.
> 
> I didn't check that making it crash here would work.  If someone
> else did, then we can remove them here too.

Attachment: check_pos.diff
Description: Text document

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
Where's SANDY DUNCAN?

[Prev in Thread] Current Thread [Next in Thread]