[Freeciv-Dev] Re: [Patch][RFC] Reduce superfluous tile_info packets

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Wed, Oct 24, 2001 at 06:17:44PM -0400, Jason Dorje Short wrote:
> Raimar Falke wrote:
> > 
> > The attached patch is a rough first version of a patch which change
> > the server to only sent tile information if this information has
> > really changed.
> > 
> > Test: loading a normal game (1600AD) and pressing three times return.
> > Results (packet type 7 is tile info):
> > 
> >   without patch:
> > 2:   [ 7]:  41882 packets;   376938 bytes total;     9 bytes/packet average
> > 2: transmitted 534864 bytes in 44000 packets;average size per packet 12 
> > bytes
> > 
> >   with patch:
> > 2:   [ 7]:   4076 packets;    36684 bytes total;     9 bytes/packet average
> > 2: transmitted 185739 bytes in 6000 packets;average size per packet 30 bytes
> > 
> > Note that 4000 packets are needed at the start to transfer all tiles
> > to the client. The human player has the Apollo Program.
> 
> Wow, is that for real?

Yes.

> Some technical comments:
> 
> The "n" parameter of map_tile_set_changed does nothing, right?  It's just a
> temporary debugging tool?

Yes. Yes.

> What is the purpose of base_map_[set|clear]_special?

The settler code changes the special and resets it two lines
later. This should cause this tile to be marked changed and sent to
the tile.

> In map_[set|clear]_special, you can't call MAP_TILE before
> normalizing (until we move to the check_map_pos system, anyway).

I know.

As I said this is only a first version.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
  Living on earth may be expensive, but it includes an annual free trip
  around the sun.