Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2001:
[Freeciv-Dev] Re: PATCH: check_map_pos
Home

[Freeciv-Dev] Re: PATCH: check_map_pos

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxx
Cc: freeciv-dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: PATCH: check_map_pos
From: Gaute B Strokkenes <gs234@xxxxxxxxx>
Date: Mon, 22 Oct 2001 02:59:15 +0100

On Mon, 15 Oct 2001, vze2zq63@xxxxxxxxxxx wrote:
> 
> Unfortunately the client isn't ready for this change.  It will fail
> the assertion after a little while.

We could make the abort conditional on is_server if need be, as a
temporary measure.

> Fine.  Only two things: the macro can not be used inside map_inx,

Why not?

> and map_inx is where the problems are most likely to occur.  Also,
> I'd prefer to keep the name check_map_pos (instead of
> check_map_pos); the macro can ensure that passed parameters are not
> evaluated more than once.

You're not coming across here.  check_map_pos instead of
check_map_pos?

> In the meantime I can try to track down the client problems,
> although they may be GUI-specific.

Please do.  You seem to be on a quest to add arbitrarily complex maps
to Freeciv; this is your chance to put your money where your mouth is
and show that someone is actually willing to go through the GUI code
and make it possible to show them on the map, a problem which is more
complicated than dealing with them internally.

-- 
Big Gaute                               http://www.srcf.ucam.org/~gs234/
America!!  I saw it all!!  Vomiting!  Waving!  JERRY FALWELLING into
 your void tube of UHF oblivion!!  SAFEWAY of the mind --


[Prev in Thread] Current Thread [Next in Thread]