Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2001:
[Freeciv-Dev] Re: PATCH: check_map_pos
Home

[Freeciv-Dev] Re: PATCH: check_map_pos

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: freeciv-dev <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: PATCH: check_map_pos
From: Jason Dorje Short <vze2zq63@xxxxxxxxxxx>
Date: Tue, 16 Oct 2001 00:39:46 -0400
Reply-to: jdorje@xxxxxxxxxxxx

Raimar Falke wrote:
> 
> On Mon, Oct 15, 2001 at 02:59:51PM -0400, Jason Dorje Short wrote:

> > Index: client/control.c
> > ===================================================================
> > RCS file: /home/freeciv/CVS/freeciv/client/control.c,v
> > retrieving revision 1.60
> > diff -u -r1.60 control.c
> > --- client/control.c  2001/09/15 15:31:19     1.60
> > +++ client/control.c  2001/10/15 18:49:30
> > @@ -1033,7 +1033,7 @@
> >    was_teleported=!is_tiles_adjacent(punit->x, punit->y, pinfo->x, 
> > pinfo->y);
> >    x=punit->x;
> >    y=punit->y;
> 
> > -  punit->x=-1;  /* focus hack - if we're moving the unit in focus, it wont
> > +  /* punit->x=-1; */  /* focus hack - if we're moving the unit in focus, 
> > it wont
> >                * be redrawn on top of the city */
> 
> No. Either remove it or leave it there.

(Note that this patch is submitted for testing, NOT for inclusion into
CVS.)

Clearly something must be done about this code, but what?  Is this
"hack" needed?  If so, how else can the problem be worked around?  Is it
safe to just remove this code?

jason


[Prev in Thread] Current Thread [Next in Thread]