[Freeciv-Dev] Re: PATCH: check_map_pos

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Mon, Oct 15, 2001 at 04:29:10AM -0400, Jason Dorje Short wrote:
> The attached patch introduces a check_map_pos() function.
> 
> It's done as an inline function within map.h, but this is unimportant at
> this point.  As said before, the advantage of a function is that it can
> be used within map_inx if desired; there's not really any advantage to a
> macro.
> 
> It does not touch client code.  With all the different GUI's and the
> tendancy to pass around coordinates picked by the user, the client is
> not yet ready for this function.
> 
> I have run several full (endyear=2000) autogames, and have not had any
> problems yet.
> 
> Note that check_map_pos is not called on coordinates that are simply
> passed off to another function; for instance most of the code in map.c
> just calls MAP_TILE or map_inx with the coordinates so it's not
> necessary to call check_map_pos directly.

So since the code base is ready for the change we have to discuss
about the form. IMHO we should use macros to be able to completely
disable this checks. IMHO it isn't a good idea to mix these two things
(introduction of check_map_pos and inline).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 checking for the vaidity of the Maxwell laws on this machine... ok
 checking if e=mc^2... ok
 checking if we can safely swap on /dev/fd0... yes
    -- kvirc 2.0.0's configure