[Freeciv-Dev] Re: PATCH: remove map_adjust_[xy] invocations from server
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
On Fri, 05 Oct 2001, vze2zq63@xxxxxxxxxxx wrote:
>> We may avoid the function call if is_normal_map_pos is a
>> macro. And with the RANGE_CHECK_0 from Ross there would also be no
>> double evaluation.
>
> Well, whatever. Should I add RANGE_CHECK_0 just for this patch?
> Shouldn't that be its own patch? Would you rather I propose that
> patch first? Should I make this into a macro? What is the
> consensus on any of these issues?
Don't bother, unless you can show (with a profile) that doing so
actually improves performance. When I tried this trick, it did not.
--
Big Gaute http://www.srcf.ucam.org/~gs234/
CALIFORNIA is where people from IOWA or NEW YORK go to subscribe to
CABLE TELEVISION!!
|
|
