[Freeciv-Dev] Re: PATCH: remove map_adjust_[xy] invocations from server (PR#989)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Tue, Oct 09, 2001 at 02:58:28AM -0400, Ross W. Wetmore wrote:
> I have lost context on these so you may be right that the x,y values
> are always guaranteed to be real.
> 
> But the assert is useful to check this when you may still be passing
> unreal coordinates (as in tilespec.c() and other places that still 
> have (x+1,y-1) type code constructs).
> 
> Note that "real" is not always "normalized", so that normalize_map_pos
> (i.e. normalization) is often still required. 

> The code does not yet guarantee that passed coordinates are always
> normalized as well as real.

We want this in the future. And I can assure you we are 99% there in
the auto games.

> You want to go slower in things like map.c changes elsewhere.

> If there had been an if(normalized_map_pos()), then you would definitely
> be right, all the time.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The Internet is really just a series of bottlenecks 
  joined by high speed networks."
    -- Sam Wilson