[Freeciv-Dev] Re: [Patch] Request ids (PR#940)

[Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>]

On Sat, Sep 08, 2001 at 02:14:10PM +0200, Raimar Falke wrote:
> On Sat, Sep 08, 2001 at 03:59:41AM -0700, Trent Piepho wrote:
> > On Thu, 6 Sep 2001 rf13@xxxxxxxxxxxxxxxxxxxxxx wrote:
> > > This patch implements request ids (formerly knows as serial
> > > numbers). Every client->server packet is called request. The client
> > > will put a uint16 (the request id) after the bytes of the normal
> > 
> > Why do you need to send the ID?  If the first request from the >
> > client has the > id 0, then second has id 1, and so on, then there
> > is no reason that the server > has to be told this.

These are really not needed. The patch reduces the overhead to 6 bytes
per request.

> > You're patch increases the move unit packet from 7 bytes to 9, that's 29%.
> > 
> > For the server, it's even worse.  You don't do any buffering, so when a unit
> > moves the server will end up sending 3 TCP/IP packets instead of just 1. 
> 
> It is no problem to do buffer() and unbuffer() calls.

Implemented.

>> The unit info packet already has a serial number in it.  I wonder
>> what it's used for?

This may can be removed if the request ids are applied.

If there are no objects I will apply the patch.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The two rules for success in life are:
  1) Never tell them everything you know."

sno4.diff.gz
Description: GNU Zip compressed data