Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: 3 patches for use on public gameservers

[Freeciv-Dev] Re: 3 patches for use on public gameservers

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Cc: Reinier Post <rp@xxxxxxxxxx>, Raimar Falke <hawk@xxxxxxxxxxxxxxxxxxxxxxx>, freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: 3 patches for use on public gameservers
From: "Ross W. Wetmore" <rwetmore@xxxxxxxxxxxx>
Date: Wed, 29 Aug 2001 22:11:23 -0400

At 12:59 PM 01/08/28 -0400, Jason Dorje Short wrote:
>Reinier Post wrote:
>> And I'd hope to see more comments on the trivial patches of
>Setting the minimum timeout to 40 is definitely good for public games. 
>However, it will make debugging harder since it's convenient to set the
>timeout to -1 or 1.  I was going to suggest that the 40 minimum be tied
>to NDEBUG, but of course most public games are compiled with debugging
>anyway.  In any case, this functionality is especially important because
>I just went to a game and changed the timeout to
>-1 ... this simply can't be allowed.

Release versions should always be compiled with NDEBUG. Don't even consider
doing it otherwise. That is what the flag is for, and having to invent 
another one that is REALLY_REALLY_REALLY_DEBUG is a tad foolish.

It is sufficient to do the trivial thing and have the patch update just one 
of the two values in current CVS, i.e. the one that isn't set to -1. One
shouldn't need to have to comment on this.

And maintainers should be capable of merging such diffs into CVS, even if
they have been allowed to bit-rot for a few weeks :-).


[Prev in Thread] Current Thread [Next in Thread]