Complete.Org: Mailing Lists: Archives: freeciv-dev: August 2001:
[Freeciv-Dev] Re: patches

[Freeciv-Dev] Re: patches

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: rf13@xxxxxxxxxxxxxxxxxxxxxx
Cc: freeciv development list <freeciv-dev@xxxxxxxxxxx>
Subject: [Freeciv-Dev] Re: patches
From: Trent Piepho <xyzzy@xxxxxxxxxxxxx>
Date: Wed, 29 Aug 2001 13:06:01 -0700 (PDT)

On Wed, 29 Aug 2001, Raimar Falke wrote:
> The attached patch should clean up any remaining ids of players,
> cities and units. Unit types have an extra type (good). Still a bit of
> a mess are improvements.

This part is wrong:

@@ -823,7 +823,9 @@
-                             ((struct packet_generic_integer *)packet)->value);
+                             get_player(
+                                        ((struct packet_generic_integer *)
+                                         packet)->value));

This is a network function, and should take an ID as a parameter.  Every
single other network function works that way.  In the 51 other handler
functions called in that case statement, not one has some kind of id to
pointer function used in its arguments.

[Prev in Thread] Current Thread [Next in Thread]