[Freeciv-Dev] Re: patches

[Trent Piepho <xyzzy@xxxxxxxxxxxxx>]

On Wed, 29 Aug 2001, Raimar Falke wrote:
> The attached patch should clean up any remaining ids of players,
> cities and units. Unit types have an extra type (good). Still a bit of
> a mess are improvements.

This part is wrong:

@@ -823,7 +823,9 @@
     break;
   case PACKET_PLAYER_CANCEL_PACT:
     handle_player_cancel_pact(pplayer,
-                             ((struct packet_generic_integer *)packet)->value);
+                             get_player(
+                                        ((struct packet_generic_integer *)
+                                         packet)->value));


This is a network function, and should take an ID as a parameter.  Every
single other network function works that way.  In the 51 other handler
functions called in that case statement, not one has some kind of id to
pointer function used in its arguments.